ENH Use symfony/validation logic #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
GuySartorelli
force-pushed
the
pulls/4/symfony-validation
branch
from
d33a9d5 to
e6a0f2d
Compare
GuySartorelli
commented
Sep 24, 2024
| use SilverStripe\Forms\DropdownField; | ||
| use SilverStripe\Forms\FieldList; | ||
| use SilverStripe\Forms\TextField; | ||
| use SilverStripe\ORM\FieldType\DBField; | ||
| use SilverStripe\Core\Validation\ValidationException; |
|
Just realised I misunderstood the existing validation, which allows for relative paths as well as absolute ones and is only intended to avoid non-HTTP(s) absolute URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes in silverstripe/silverstripe-framework#11399
Issue
symfony/validatorfor as much validation logic as we can throw at it. .github#193